fix: Complete-k8s output & add try to prometheus policy element index

[Zvikan]

What does this PR do?

• adds try to complete-k8s output with default null option
• adds try to prometheus element index with default empty string
• disables terraform creating cw log group for fluentbit in complete-k8s example

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

• Following failures e2e cleanup where we can see the following failures:

Error: Attempt to index null value

  on outputs.tf line 18, in output "kyverno_values":
  18:   value       = jsondecode(module.eks_blueprints_kubernetes_addons.kyverno.release_metadata[0].values)
    ├────────────────
    │ module.eks_blueprints_kubernetes_addons.kyverno.release_metadata is null

This value is null, so it does not have any indices.

Error: Invalid index

  on ../../modules/kubernetes-addons/prometheus/main.tf line 112, in module "irsa_amp_ingest":
 112:   irsa_iam_policies             = [aws_iam_policy.ingest[0].arn]
    ├────────────────
    │ aws_iam_policy.ingest is empty tuple

• following e2e creation of the complete-k8s-addons example failure due to log group already exists

Error: Creating CloudWatch Log Group failed: ResourceAlreadyExistsException: The specified log group already exists:  The CloudWatch Log Group '/complete-kubernetes-addons/worker-fluentbit-logs' already exists.

  with module.eks_blueprints_kubernetes_addons.module.aws_for_fluent_bit[0].aws_cloudwatch_log_group.aws_for_fluent_bit[0],
  on ../../modules/kubernetes-addons/aws-for-fluentbit/main.tf line 10, in resource "aws_cloudwatch_log_group" "aws_for_fluent_bit":
  10: resource "aws_cloudwatch_log_group" "aws_for_fluent_bit" {

Even after cleaning up the log group manually it seems the workload itself is creating the log group again, therefore for the example disabling Terraform from managing the CW log group

More

• Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
• Yes, I have added a new example under examples to support my PR
• Yes, I have created another PR for add-ons under add-ons repo (if applicable)
• Yes, I have updated the docs for this feature
• Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

• Use an existing example when possible to demonstrate a new addons usage
• A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

• E2E Test successfully complete before merge?

Additional Notes

[askulkarni2]

Not sure I understand this one.

[Zvikan]

I am not sure if this is the best solution, but right now if you are trying to cleanup the complete-k8s addon for example, you'll face the failure explained in the details of the PR where aws_iam_policy.ingest is empty tuple , when you try to the delete the resource (that was already deleted), because it's under a condition (if mng prometheus is enabled), this was the cleanest workaround I found. Terraform is trying to use the resource because it's also being used in the rest of the prometheus module and because it has that count condition

[bryantbiggs]

it fixes an error so for now we'll go with it - we can revisit later to see if there is a better or more idiomatic way to resolve this

[that-kampe-steak]

fyi: This still happens in 4.22