Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revert node groups deletion #1204

Merged
merged 3 commits into from
Nov 23, 2022
Merged

docs: Revert node groups deletion #1204

merged 3 commits into from
Nov 23, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Nov 23, 2022

What does this PR do?

  • Revert deletion of node groups docs

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Post https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/1104/files which lead to #1142, later on we reverted the node groups examples (#1121) but forgot to revert the docs for the node groups.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test November 23, 2022 16:45 Inactive
@edmiranda
Copy link
Contributor

@Zvikan thanks for opening this PR

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs 👍🏼

@askulkarni2 askulkarni2 changed the title Docs: revert node groups deletion docs: Revert node groups deletion Nov 23, 2022
@Zvikan Zvikan merged commit bb52577 into main Nov 23, 2022
@Zvikan Zvikan deleted the docs/node-group branch November 23, 2022 18:10
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants