-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update crossplane module #1220
feat: Update crossplane module #1220
Conversation
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
need to another delay 30s, for kubernetes providerconfig
And is because it takes some time for crossplane to install the kubernetes package provider, and for the CRD for provider config for kubernetes to be established. |
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
resource "kubectl_manifest" "aws_controller_config" { | ||
count = try(local.aws_provider.enable, true) ? 1 : 0 | ||
yaml_body = templatefile("${path.module}/aws-provider/aws-controller-config.yaml", { | ||
iam-role-arn = module.aws_provider_irsa[0].irsa_iam_role_arn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryantbiggs I figured out how to handle the role in a better way
Signed-off-by: Carlos Santana <csantana23@gmail.com>
fixed the problem with
|
Signed-off-by: Carlos Santana <csantana23@gmail.com>
ok I'm done with all the changes and tests @bryantbiggs please take a another look to this PR and let me know what else should we change to get it merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
… into crossplane-updates-11-28
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Resolves undefined
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Resolves undefined
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes