-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding cluster upgrade in blue-green with route53 example #1255
Conversation
public_subnet_tags = { | ||
"kubernetes.io/cluster/${local.name}-blue" = "shared" | ||
"kubernetes.io/cluster/${local.name}-green" = "shared" | ||
"kubernetes.io/cluster/${local.name}-nodomain" = "shared" | ||
"kubernetes.io/role/elb" = "1" | ||
} | ||
|
||
private_subnet_tags = { | ||
"kubernetes.io/cluster/${local.name}-blue" = "shared" | ||
"kubernetes.io/cluster/${local.name}-green" = "shared" | ||
"kubernetes.io/cluster/${local.name}-nodomain" = "shared" | ||
"kubernetes.io/role/internal-elb" = "1" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tags still required? Afaik only the "kubernetes.io/role/elb" = "1"
is required.
public_subnet_tags = { | |
"kubernetes.io/cluster/${local.name}-blue" = "shared" | |
"kubernetes.io/cluster/${local.name}-green" = "shared" | |
"kubernetes.io/cluster/${local.name}-nodomain" = "shared" | |
"kubernetes.io/role/elb" = "1" | |
} | |
private_subnet_tags = { | |
"kubernetes.io/cluster/${local.name}-blue" = "shared" | |
"kubernetes.io/cluster/${local.name}-green" = "shared" | |
"kubernetes.io/cluster/${local.name}-nodomain" = "shared" | |
"kubernetes.io/role/internal-elb" = "1" | |
} | |
public_subnet_tags = { | |
"kubernetes.io/role/elb" = "1" | |
} | |
private_subnet_tags = { | |
"kubernetes.io/role/internal-elb" = "1" | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll test this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yes this is needed for Karpenter, we uses it in the subnet selector
subnetSelector:
kubernetes.io/cluster/{{ .Values.spec.clusterName }}: '*'
kubernetes.io/role/internal-elb: '1' # to select only private subnets
Without this, your Karpenter nodes could be created in another VPC used maybe by another cluster
examples/upgrade/blue-green-route53/eks-green/kubernetes/ecsdemo-crystal/limit-range.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Apoorva Kulkarni <askulkarni84@gmail.com>
Co-authored-by: Apoorva Kulkarni <askulkarni84@gmail.com>
Co-authored-by: Apoorva Kulkarni <askulkarni84@gmail.com>
Eks cluster
examples/upgrade/blue-green-route53/modules/eks_cluster/main.tf
Outdated
Show resolved
Hide resolved
examples/upgrade/blue-green-route53/modules/eks_cluster/outputs.tf
Outdated
Show resolved
Hide resolved
Signed-off-by: sallaman <sallaman@amazon.com>
…ia#1255) Signed-off-by: sallaman <sallaman@amazon.com> Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Signed-off-by: sallaman <sallaman@amazon.com> Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
What does this PR do?
This add a sample to allow Canary EKS cluster migration for ArgoCD stateless workloads using Route53 weighted records.
The changes in Route53 weighted are managed with Terraform variable from the 2 clusters.
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes