Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Minor typo on comments #1266

Merged
merged 1 commit into from
Dec 20, 2022
Merged

chore: Minor typo on comments #1266

merged 1 commit into from
Dec 20, 2022

Conversation

kbumsik
Copy link
Contributor

@kbumsik kbumsik commented Dec 20, 2022

What does this PR do?

Distinguish between self-managed and EKS managed.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@kbumsik
doc(outputs.tf): Minor typo on comments
ac4c45d 
Distinguish between self-managed and EKS managed.
@kbumsik kbumsik requested a review from a team as a code owner December 20, 2022 10:55
@kbumsik kbumsik temporarily deployed to EKS Blueprints Test December 20, 2022 10:55 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@vara-bonthu vara-bonthu changed the title doc(outputs.tf): Minor typo on comments chore: Minor typo on comments Dec 20, 2022
@Zvikan Zvikan merged commit 8599948 into aws-ia:main Dec 20, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@kbumsik @allamand
chore: Minor typo on comments (aws-ia#1266)
7116ada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbumsik @vara-bonthu @Zvikan