Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correcting namespace for csi-secret-store-provider-aws module #1281

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

MaiCabrera
Copy link
Contributor

@MaiCabrera MaiCabrera commented Dec 26, 2022

What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation
Trying to just leverage the csi secret store module to mount secrets to my main microservices

Resolves #1172

@MaiCabrera MaiCabrera requested a review from a team as a code owner December 26, 2022 21:03
@MaiCabrera MaiCabrera changed the title update: adding ns kube-system Fix: adding ns kube-system Dec 26, 2022
@MaiCabrera MaiCabrera changed the title Fix: adding ns kube-system Fix: adding ns kube-system as default in csi secrets store provider module Dec 26, 2022
@MaiCabrera MaiCabrera changed the title Fix: adding ns kube-system as default in csi secrets store provider module fix: adding ns kube-system as default in csi secrets store provider module Dec 26, 2022
@MaiCabrera MaiCabrera changed the title fix: adding ns kube-system as default in csi secrets store provider module fix: Correcting namespace for csi-secret-store-provider-aws module Dec 26, 2022
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test December 27, 2022 00:56 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit 37487cc into aws-ia:main Dec 27, 2022
@nahum-landa
Copy link
Contributor

Error: namespaces "kube-system" already exists

│ with module.kubernetes_addons.module.csi_secrets_store_provider_aws[0].kubernetes_namespace_v1.csi_secrets_store_provider_aws,
│ on .terraform/modules/kubernetes_addons/modules/kubernetes-addons/csi-secrets-store-provider-aws/main.tf line 6, in resource "kubernetes_namespace_v1" "csi_secrets_store_provider_aws":
│ 6: resource "kubernetes_namespace_v1" "csi_secrets_store_provider_aws" {

@csantanapr
Copy link
Contributor

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
…ws-ia#1281)

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Resolves aws-ia#1172
@MaiCabrera MaiCabrera deleted the csiproviderfix branch January 23, 2023 23:55
@MaiCabrera MaiCabrera restored the csiproviderfix branch January 23, 2023 23:55
@MaiCabrera MaiCabrera deleted the csiproviderfix branch January 23, 2023 23:55
vara-bonthu pushed a commit that referenced this pull request Feb 2, 2023
…1281)

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Resolves #1172
@lordz-ei
Copy link

Creating the namespace should be optional now https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/csi-secrets-store-provider-aws/main.tf#L6

Nope, still tries to create namespace if namespace is kube-system.

@lordz-md
Copy link

lordz-md commented Mar 30, 2023

saibossai added a commit to saibossai/terraform-aws-eks-blueprints that referenced this pull request Mar 30, 2023
@saibossai
Copy link

Created the pr: #1525 to fix the namespace creation issue if the namespace: kube-system already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants