Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update karpenter example to use the EKS module, latest version of Karpenter, and run on Fargate #1297

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Update the karpenter example to:
    • Use the terraform-aws-eks module for cluster creation
    • Use the latest Karpenter settings and recommendations (i.e. - AWSNodeTemplate, consolidation, native spot termination handling, etc.)
    • Run Karpenter on EKS Fargate
  • Update the karpenter addon to allow passing in a computed SQS ARN value without error and use the latest Karpenter release version
  • Remove Datadog operator addon from example - requires an API key

Motivation

  • Updates the example blueprint to the current practices used when running Karpenter on EKS

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner January 6, 2023 20:26
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test January 6, 2023 20:27 — with GitHub Actions Inactive
}

data "aws_ecrpublic_authorization_token" "token" {
provider = aws.virginia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

Copy link
Contributor

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


cluster_name = local.name
cluster_version = "1.24"
cluster_endpoint_public_access = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bad example default, from a security point of view, considering many will opy the examples as their deployment reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all examples, minus the fully private example, have the public endpoint enabled. This was done intentionally to make it easier to get started with interacting with the clusters from the examples as well as for testing from the GitHub workflows. The only change here is that it is now explicitly clear that the public endpoint is being enabled

Was there some value that was meant to be added by posting this comment?

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
vara-bonthu pushed a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants