-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update karpenter
example to use the EKS module, latest version of Karpenter, and run on Fargate
#1297
Conversation
…n of Karpenter, and run on Fargate
} | ||
|
||
data "aws_ecrpublic_authorization_token" "token" { | ||
provider = aws.virginia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
||
cluster_name = local.name | ||
cluster_version = "1.24" | ||
cluster_endpoint_public_access = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bad example default, from a security point of view, considering many will opy the examples as their deployment reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all examples, minus the fully private example, have the public endpoint enabled. This was done intentionally to make it easier to get started with interacting with the clusters from the examples as well as for testing from the GitHub workflows. The only change here is that it is now explicitly clear that the public endpoint is being enabled
Was there some value that was meant to be added by posting this comment?
…n of Karpenter, and run on Fargate (aws-ia#1297)
…n of Karpenter, and run on Fargate (#1297)
What does this PR do?
karpenter
example to:terraform-aws-eks
module for cluster creationAWSNodeTemplate
, consolidation, native spot termination handling, etc.)karpenter
addon to allow passing in a computed SQS ARN value without error and use the latest Karpenter release versionMotivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes