Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Datadog not been managed by argocd #1305

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

nahum-landa
Copy link
Contributor

@nahum-landa nahum-landa commented Jan 8, 2023

this will make the app of apps work for datadog.

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

this will make the app of apps work.
@nahum-landa nahum-landa requested a review from a team as a code owner January 8, 2023 12:00
@nahum-landa nahum-landa temporarily deployed to EKS Blueprints Test January 8, 2023 12:00 — with GitHub Actions Inactive
@nahum-landa nahum-landa changed the title fix datadog not been managed by argocd fix: datadog not been managed by argocd Jan 8, 2023
@nahum-landa nahum-landa changed the title fix: datadog not been managed by argocd fix: Datadog not been managed by argocd Jan 9, 2023
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for fixing this!

@Zvikan Zvikan merged commit d2e4d8d into aws-ia:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants