Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure only the 10.0.* subnet range is assigned to nodes for vpc-cni-custom-networking example #1315

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: Ensure only the 10.0.* subnet range is assigned to nodes for vpc-cni-custom-networking example #1315

merged 1 commit into from
Jan 10, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Ensure only the 10.0.* subnet range is assigned to nodes for vpc-cni-custom-networking example

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner January 10, 2023 13:36
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test January 10, 2023 13:36 — with GitHub Actions Inactive
csantanapr
csantanapr approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@csantanapr csantanapr merged commit dbac512 into main Jan 10, 2023
@csantanapr csantanapr deleted the fix/custom-networking branch January 10, 2023 14:24
vara-bonthu pushed a commit that referenced this pull request Feb 2, 2023
@bryantbiggs @vara-bonthu
fix: Ensure only the 10.0.* subnet range is assigned to nodes for `vp…
44b7ecb 
…c-cni-custom-networking` example (#1315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodes should not use secondary CIDR in example vpc custom cni
2 participants
@bryantbiggs @csantanapr