-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update serverless clusters running EKS Farage to maximize resource utilization on CoreDNS #1329
Conversation
…rce utilization on CoreDNS
@@ -53,6 +53,18 @@ module "eks" { | |||
coredns = { | |||
configuration_values = jsonencode({ | |||
computeType = "Fargate" | |||
# Ensure that the we fully utilize the minimum amount of resources that are supplied by | |||
# Fargate https://docs.aws.amazon.com/AmazonECS/latest/developerguide/AWS_Fargate.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is good to include this other link https://docs.aws.amazon.com/eks/latest/userguide/fargate-pod-configuration.html
Don't know if you want to add this link or replace the current one with this one.
This one shows that 256MB are being reserved for kubelet, kube-proxy, containerd
Fargate adds 256 MB to each pod's memory reservation for the required Kubernetes components (kubelet, kube-proxy, and containerd).
Fargate rounds up to the following compute configuration that most closely matches the sum of vCPU and memory requests in order to ensure pods always have the resources that they need to run.
And also provides an example
The additional memory reserved for the Kubernetes components can cause a Fargate task with more vCPUs than requested to be provisioned. For example, a request for 1 vCPU and 8 GB memory will have 256 MB added to its memory request, and will provision a Fargate task with 2 vCPUs and 9 GB memory, since no task with 1 vCPU and 9 GB memory is available.
Just thinking out loud, I think having this as tip and script/tool to scanned a cluster using fargate and calculate total waste of resources. This can be a cost and performance optimization tip/script during evaluation of a cluster config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
looks good now
|
…rce utilization on CoreDNS (#1329)
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes