Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Escape regex validation backslash #1518

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

naxgrp-johnthompson
Copy link
Contributor

What does this PR do?

This fixes a recent change that broke the argocd addon variables file -- i escaped the backslash before the dot so that it's a valid regex.

@naxgrp-johnthompson naxgrp-johnthompson requested a review from a team as a code owner March 29, 2023 19:08
@naxgrp-johnthompson naxgrp-johnthompson temporarily deployed to EKS Blueprints Test March 29, 2023 19:08 — with GitHub Actions Inactive
@bryantbiggs
Copy link
Contributor

can you provide supporting evidence that shows its currently invalid?

@brian-garza
Copy link

brian-garza commented Mar 29, 2023

I did run into this error as well, so I believe this PR should help.

image

#1519 (comment)

@naxgrp-johnthompson
Copy link
Contributor Author

terraform first tries to escape the string before it parses the regex, so you need to escape the escape character.

@kol-ratner
Copy link

this is affecting production for a major aws migration effort for Sovrn as well, please push this through

@askulkarni2
Copy link
Contributor

askulkarni2 commented Mar 29, 2023

We are looking into it, as a best practice please pin your module usage to the latest released version, in this case 4.26.0.

@bryantbiggs bryantbiggs changed the title escape backslash fix: Escape regex validation backslash Mar 29, 2023
@bryantbiggs bryantbiggs merged commit b855da6 into aws-ia:main Mar 29, 2023
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants