Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrades: Terraform -> v1.0.0, AWS TF Provider -> v3.37.0, AWS TF EKS module -> v15.2.0 #5

Closed
wants to merge 3 commits into from

Conversation

awsitcloudpro
Copy link
Contributor

Issue #, if available:
Issue #4

Description of changes:
Changes necessary to use this repo with Terraform v0.15.0 / v1.0.0:

  • Used TF function tomap() instead of map(), which is deprecated and no longer available.
  • Used TF function tolist() instead of list(), which is deprecated and no longer available. The list() function was used in the older version of the dependency module terraform-aws-modules/eks/aws, so to it was necessary to upgrade the module version to 15.2.0, which in turn also necessitated TF AWS provider version upgrade to 3.37.0.
  • Updated Deployment Steps in README to use the source directory as the current working directory, as required by TF v0.15.0+. Also fixed the pre-requisites bullets.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…updates for AWS provider to v3.37.0 and EKS module to v15.2.0
@vara-bonthu
Copy link
Contributor

@awsitcloudpro Thanks for your contribution. I will review and test the PR this weekend and merge it accordingly

@awsitcloudpro
Copy link
Contributor Author

@vara-bonthu I had forgotten to update Makefile, did that now.

@vara-bonthu
Copy link
Contributor

@awsitcloudpro Could you please resolve the conflicts and submit the PR? Alos, Please ensure your Terraform version update is working end to end by deploying the DEV cluster as per the instructions end to end

@awsitcloudpro
Copy link
Contributor Author

@vara-bonthu I have resolved the conflicts that happened due to the recent main branch commits. I have also re-tested the version upgrade end-to-end, including Agones and Traefik IC deployment. Everything worked well.

@awsitcloudpro
Copy link
Contributor Author

Closing, as the new release incorporates TF version upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants