Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade K8s auth API due to deprecation #646

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Upgrade K8s auth API version from v1alpha1 to v1beta1 in examples exec blocks. The guidance for users from the issues referenced below is:
    • Update your awscli to at least 2.7x
    • You may need to remove your kubeconfig locally and re-run aws eks update-kubeconfig --name ... to update the auth version used in your local kubeconfig
  • Update CI workflow actions provide by GitHub to latest which use Node16

Motivation

  • Terratest is currently failing with the following error:
TestEksBlueprintsE2E 2022-06-17T19:55:26Z logger.go:66: Error: Kubernetes cluster unreachable: exec plugin: invalid apiVersion "client.authentication.k8s.io/v1alpha1"

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test June 17, 2022 20:47 Inactive
@@ -1,7 +1,9 @@
name: Check Markdown links

on:
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change from PR to push - glad you asked!

If you add new docs and new link, your PR will fail - see #407

The link won't be live and available to test properly until after merging and the GH pages are live. We also might want to bake this into the gh-page deploy pipeline and add a badge or something to ensure links are all good on main

@@ -20,8 +20,9 @@ jobs:
outputs:
directories: ${{ steps.dirs.outputs.directories }}
steps:
- run: aws --version
Copy link
Contributor Author

@bryantbiggs bryantbiggs Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this jives with the findings - looks like GitHub updated the runners to use the latest awscli which means the aws eks update-kubeconfig --name ... is going to pull v1beta1

aws-cli/2.7.7 Python/3.9.11 Linux/5.13.0-1029-azure exe/x86_64.ubuntu.20 prompt/off

Ref: https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/6942642586?check_suite_focus=true

Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep an eye post merge to see if this is causing issues as now users will need to upgrade to AWS CLI version >=2.7.X
Ideally we should encourage using non-deprecated api versions whenever possible.
LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants