-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade K8s auth API due to deprecation #646
Conversation
@@ -1,7 +1,9 @@ | |||
name: Check Markdown links | |||
|
|||
on: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change from PR to push - glad you asked!
If you add new docs and new link, your PR will fail - see #407
The link won't be live and available to test properly until after merging and the GH pages are live. We also might want to bake this into the gh-page deploy pipeline and add a badge or something to ensure links are all good on main
@@ -20,8 +20,9 @@ jobs: | |||
outputs: | |||
directories: ${{ steps.dirs.outputs.directories }} | |||
steps: | |||
- run: aws --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this jives with the findings - looks like GitHub updated the runners to use the latest awscli which means the aws eks update-kubeconfig --name ...
is going to pull v1beta1
aws-cli/2.7.7 Python/3.9.11 Linux/5.13.0-1029-azure exe/x86_64.ubuntu.20 prompt/off
Ref: https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/6942642586?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should keep an eye post merge to see if this is causing issues as now users will need to upgrade to AWS CLI version >=2.7.X
Ideally we should encourage using non-deprecated api versions whenever possible.
LGTM.
What does this PR do?
v1alpha1
tov1beta1
in examples exec blocks. The guidance for users from the issues referenced below is:kubeconfig
locally and re-runaws eks update-kubeconfig --name ...
to update the auth version used in your local kubeconfigMotivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes