Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add smb-csi-driver to Kubernetes addon #930

Merged
merged 2 commits into from
Sep 6, 2022
Merged

feat: Add smb-csi-driver to Kubernetes addon #930

merged 2 commits into from
Sep 6, 2022

Conversation

florentio
Copy link
Contributor

@florentio florentio commented Sep 4, 2022 •
edited by bryantbiggs
Loading

What does this PR do?

Closes #522

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@florentio florentio mentioned this pull request Sep 4, 2022
Merged
@florentio florentio temporarily deployed to EKS Blueprints Test September 4, 2022 14:56 Inactive
bryantbiggs
bryantbiggs approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit 0cf8e9c into aws-ia:main Sep 6, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@florentio @allamand
feat: Add smb-csi-driver to Kubernetes addon (aws-ia#930)
241b18e 
* feat: Add smb-csi-driver to Kubernetes addon

* fix: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADDON]Will be good to have SMB CSI driver add-on on this blueprint
2 participants
@florentio @bryantbiggs