Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This directory doesn't exist in the repo. #936

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

wkopl
Copy link
Contributor

@wkopl wkopl commented Sep 7, 2022

The examples/eks-cluster-with-karpenter/ directory doesn't exist. Is it intended to be examples/karpenter/ ?

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

The examples/eks-cluster-with-karpenter/ directory doesn't exist.  Is it intended to be examples/karpenter/ ?
@wkopl wkopl temporarily deployed to EKS Blueprints Test September 7, 2022 15:52 Inactive
@bryantbiggs bryantbiggs merged commit 775f685 into aws-ia:main Sep 7, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants