Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix argocd_manage_add_ons not passed to external_secrets module #957

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

atorrescogollo
Copy link
Contributor

What does this PR do?

When enabling external_secrets addon, it will deploy the helm chart regardless of what you configured through argocd_manage_add_ons. It should instead create only AWS IAM stuff and the namespace with the service account.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@atorrescogollo atorrescogollo temporarily deployed to EKS Blueprints Test September 13, 2022 15:18 Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@askulkarni2 askulkarni2 merged commit 4154021 into aws-ia:main Sep 14, 2022
@jochemvankessel
Copy link

I think you forgot to add a line to /main/modules/kubernetes-addons/locals.tf
The gitops config is not added there

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External secrets will install helm chart regardless of argocd_manage_add_ons configuration
3 participants