Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serviceaccount imagepullsecret support #977

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

Pacobart
Copy link
Contributor

Adding support for service accounts created with eks blueprint to use optional imagePullSecrets. This is needed due to some helm chart providers choosing to implement imagePullSecrets at the ServiceAccount object vs at the deployment/pod object(s). Cert-manager is one of these providers.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Pacobart Pacobart force-pushed the serviceaccount_imagepullsecret_support branch from 403c3b1 to c1e4f30 Compare September 20, 2022 21:34
@Pacobart Pacobart temporarily deployed to EKS Blueprints Test September 20, 2022 21:34 Inactive
@Pacobart Pacobart marked this pull request as ready for review September 20, 2022 22:25
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure for next time to have an issue created and discussed first before working on a PR (following our contribution guidelines).

Minor doc comment, other than that LGTM, going to run TF plan workflow and then will approve it. Thank you

docs/add-ons/cert-manager.md Show resolved Hide resolved
@Pacobart Pacobart temporarily deployed to EKS Blueprints Test September 21, 2022 20:44 Inactive
@Zvikan Zvikan merged commit adfbef6 into aws-ia:main Sep 21, 2022
@Pacobart Pacobart deleted the serviceaccount_imagepullsecret_support branch September 21, 2022 21:10
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
* imagePullSecrets added as option

* adding note of functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants