Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument the sample application using CWOperator. #44

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

zzhlogin
Copy link
Contributor

@zzhlogin zzhlogin commented Feb 7, 2024

This PR Instrument the sample application using CWOperator by setting up following:

  1. annotation: instrumentation.opentelemetry.io/inject-python: "true"
  2. run the server with --noreload
  3. Add DJANGO_SETTINGS_MODULE env variable.
  4. Add PYTHONPATH env variable, this is required as CWOperator instrumentation when application is mount in a specific directory instead of root.
  5. Add OTEL_TRACES_SAMPLER, this will be removed when Xray remote sampler is ready.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zzhlogin zzhlogin requested a review from a team February 7, 2024 05:02
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! approving with a minor suggestion

@zzhlogin zzhlogin merged commit 476503d into main Feb 8, 2024
14 checks passed
@zzhlogin zzhlogin deleted the main_test_operator branch February 8, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants