Add case-insensitive regex support #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyTrivail
suggested changes
Dec 10, 2020
| @@ -18,7 +18,7 @@ | |||
| "name": "HTTP GET", | |||
| "http": { | |||
| "request": { | |||
| "url": "https://aws.amazon.com/", | |||
| "url": "https://aws\\.amazon\\.com/", | |||
There was a problem hiding this comment.
you might need to change all the trace templates?
There was a problem hiding this comment.
Ah I missed all the ones nested in packages. Good catch!
There was a problem hiding this comment.
Also FWIW, even if a period wasn't escaped like this (for example in the interpolated endpoint variable), it wouldn't break validation. Because the unescaped period matches any character, including a literal period, so the correct endpoint would still be considered a match. But of course it's still better to escape them and match it exactly where we can.
wyTrivail
approved these changes
Dec 10, 2020
| @@ -18,7 +18,7 @@ | |||
| "name": "HTTP GET", | |||
| "http": { | |||
| "request": { | |||
| "url": "https://aws.amazon.com/", | |||
| "url": "https://aws\\.amazon\\.com/", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #192, this time with case-insensitive comparisons. Tested with values that had mismatched case this time. Also added
UnusedImportsto checkstyle.