-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Logging AOT Support #628
base: develop
Are you sure you want to change the base?
chore: Logging AOT Support #628
Conversation
…fic paths. New helper method to convert anonymous types to dictionary, use for source generation .NET 8
…a-dotnet into aot(logging)-support-logging
…ing the decorator. Refactor serializer for thread safety.
|
… refactor. fix bug when using logger with no decorator. more tests and new PowertoolsSourceGeneratorSerializer.cs
/// </param> | ||
private void CaptureLambdaContext(AspectEventArgs eventArgs) | ||
{ | ||
_clearLambdaContext = LoggingLambdaContext.Extract(eventArgs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check where LambdaContext is used, if just here just use the Ilambda here
|
||
#if NET8_0_OR_GREATER | ||
|
||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge methods so consumer dont need to have #if
…ion to avoid multiple #if. tests
Quality Gate passedIssues Measures |
Issue number: #212
Summary
Changes
User experience
With the new PowertoolsSourceGeneratorSerializer, we can combine Powertools SerlializationContext with the customer Serialization context, this enables Powertools to serialize customer only types, this is useful for LogEvent feature.
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.