Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): remove java 1.8 relics from the code #1659

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available: #1523

Description of changes:

Remove the latest references to java 1.8 (pom, docs, e2e tests...)

Checklist

Breaking change checklist

RFC issue #: #1523

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl changed the base branch from main to v2 June 24, 2024 10:03
Copy link

github-actions bot commented Jun 24, 2024

💾 Artifacts Size Report

Module Version Size (KB)
powertools-common 2.0.0-SNAPSHOT 9.59
powertools-serialization 2.0.0-SNAPSHOT 17.23
powertools-logging 2.0.0-SNAPSHOT 33.07
powertools-logging-log4j 2.0.0-SNAPSHOT 20.68
powertools-logging-logback 2.0.0-SNAPSHOT 16.91
powertools-tracing 2.0.0-SNAPSHOT 14.01
powertools-metrics 2.0.0-SNAPSHOT 14.05
powertools-parameters 2.0.0-SNAPSHOT 17.49
powertools-validation 2.0.0-SNAPSHOT 19.94
powertools-cloudformation 2.0.0-SNAPSHOT 16.58
powertools-idempotency-core 2.0.0-SNAPSHOT 34.63
powertools-idempotency-dynamodb 2.0.0-SNAPSHOT 12.37
powertools-large-messages 2.0.0-SNAPSHOT 17.45
powertools-batch 2.0.0-SNAPSHOT 16.89
powertools-parameters-ssm 2.0.0-SNAPSHOT 10.70
powertools-parameters-secrets 2.0.0-SNAPSHOT 9.90
powertools-parameters-dynamodb 2.0.0-SNAPSHOT 11.95
powertools-parameters-appconfig 2.0.0-SNAPSHOT 11.45

@jeromevdl jeromevdl changed the title chore: remove java 1.8 relics from the code chore(v2): remove java 1.8 relics from the code Jun 24, 2024
@scottgerring scottgerring self-requested a review June 25, 2024 15:16
@scottgerring
Copy link
Contributor

It's nice to see this getting cut out @jeromevdl :D
Couple of other bits I found:

There's a bunch of java 1.8 refs in the metrics docs still, starting here:

Depending on your version of Java (either Java 1.8 or 11+), the configuration slightly changes.

as well as large_messages.md and validation.md

build.gradle.kts for the kotlin example appears to depend on a java1.8 specific bit org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.10.

@jeromevdl
Copy link
Contributor Author

It's nice to see this getting cut out @jeromevdl :D Couple of other bits I found:

There's a bunch of java 1.8 refs in the metrics docs still, starting here:

Depending on your version of Java (either Java 1.8 or 11+), the configuration slightly changes.

as well as large_messages.md and validation.md

build.gradle.kts for the kotlin example appears to depend on a java1.8 specific bit org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.10.

  • metrics was done in the metrics v4 PR
  • validation is done in the batch validation PR
  • I missed the other 2

Copy link

sonarcloud bot commented Jun 25, 2024

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💀 java8

@jeromevdl jeromevdl merged commit adbd750 into v2 Jun 26, 2024
17 checks passed
@jeromevdl jeromevdl deleted the chore/remove-java-8 branch June 26, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants