Skip to content

Commit

Permalink
fix: case_sensitive is never None
Browse files Browse the repository at this point in the history
  • Loading branch information
Wurstnase committed Apr 12, 2024
1 parent c0622a5 commit 9210cbe
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def stage_variables(self) -> Optional[Dict[str, str]]:
return self.get("stageVariables")

@overload
def get_header_value(self, name: str, default_value: str, case_sensitive: bool = False) -> str: ...
def get_header_value(self, name: str, default_value: str, case_sensitive: Optional[bool] = False) -> str: ...

@overload
def get_header_value(
Expand Down Expand Up @@ -318,6 +318,10 @@ def get_header_value(
return get_header_value(self.headers, name, default_value, case_sensitive)


event = APIGatewayAuthorizerEventV2()
event.get_header_value(name="foo", case_sensitive=None)


class APIGatewayAuthorizerResponseV2:
"""Api Gateway HTTP API V2 payload authorizer simple response helper
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,22 +219,22 @@ def get_header_value(
self,
name: str,
default_value: str,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> str: ...

@overload
def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]: ...

def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]:
"""Get header value by name
Expand Down
6 changes: 3 additions & 3 deletions aws_lambda_powertools/utilities/data_classes/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,22 +228,22 @@ def get_header_value(
self,
name: str,
default_value: str,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> str: ...

@overload
def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]: ...

def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]:
"""Get header value by name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,22 @@ def get_header_value(
self,
name: str,
default_value: str,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> str: ...

@overload
def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]: ...

def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]:
"""Get header value by name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def get_header_value(
headers: dict[str, Any],
name: str,
default_value: str,
case_sensitive: bool | None = False,
case_sensitive: bool = False,
) -> str: ...


Expand All @@ -35,15 +35,15 @@ def get_header_value(
headers: dict[str, Any],
name: str,
default_value: str | None = None,
case_sensitive: bool | None = False,
case_sensitive: bool = False,
) -> str | None: ...


def get_header_value(
headers: dict[str, Any],
name: str,
default_value: str | None = None,
case_sensitive: bool | None = False,
case_sensitive: bool = False,
) -> str | None:
"""
Get the value of a header by its name.
Expand Down
6 changes: 3 additions & 3 deletions aws_lambda_powertools/utilities/data_classes/vpc_lattice.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,22 @@ def get_header_value(
self,
name: str,
default_value: str,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> str: ...

@overload
def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]: ...

def get_header_value(
self,
name: str,
default_value: Optional[str] = None,
case_sensitive: Optional[bool] = False,
case_sensitive: bool = False,
) -> Optional[str]:
"""Get header value by name
Expand Down

0 comments on commit 9210cbe

Please sign in to comment.