Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(event-handler): snippets split, improved, and lint #1279

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 6, 2022

Issue number: #1009

Summary

Changes

Please provide a summary of what's being changed

In addition to splitting examples, this PR also recreates all hello world examples to a contrived but functional TODO API to best demonstrate its functionalities.

User experience

Please share what the user experience looks like before and after this change

image

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/core/event_handler/api_gateway.md

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 6, 2022
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jul 6, 2022
@heitorlessa heitorlessa marked this pull request as draft July 6, 2022 15:40
@heitorlessa heitorlessa marked this pull request as ready for review July 7, 2022 14:41
* develop:
  fix: unzip the right artifact name
  fix: path to artefact
  fix: add entire ARN role instead of account and role name
  fix: no need to cache npm since we only install cdk cli and don't have .lock files
  fix: typo in input for layer workflow
  chore(layers): add release pipeline in GitHub Actions (aws-powertools#1278)
@heitorlessa heitorlessa merged commit 1170e76 into aws-powertools:develop Jul 7, 2022
@heitorlessa heitorlessa deleted the docs/event-handler-rest-code-split branch July 7, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant