-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(graphql): snippets split, improved, and lint #1287
Merged
heitorlessa
merged 16 commits into
aws-powertools:develop
from
heitorlessa:docs/event-handler-graphql-code-split
Jul 11, 2022
Merged
docs(graphql): snippets split, improved, and lint #1287
heitorlessa
merged 16 commits into
aws-powertools:develop
from
heitorlessa:docs/event-handler-graphql-code-split
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
boring-cyborg
bot
added
documentation
Improvements or additions to documentation
internal
Maintenance changes
labels
Jul 8, 2022
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Jul 8, 2022
heitorlessa
changed the title
docs(event-handler): snippets split, improved, and lint
docs(graphql): snippets split, improved, and lint
Jul 8, 2022
* develop: fix(ci): accept core arg in label related issue workflow docs(core): match code snippet name with filename (aws-powertools#1286) fix: sight, yes a whitespace character breaks the build fix: mathc the name of the cdk synth from the build phase fix: download artefact into the layer dir
pull-request-size
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jul 8, 2022
heitorlessa
added a commit
that referenced
this pull request
Jul 13, 2022
heitorlessa
added a commit
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
internal
Maintenance changes
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1009
Summary
Changes
Split, lint, and improve code examples. Also noticed we didn't have a dedicated section for
scalar_utils
.Also removed a pre-commit hook
end-of-line fixer
as it was causing productivity issues when splitting.json
files.User experience
Before
After
(NEW) Properly documented scalar utils
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/core/event_handler/appsync.md