Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(graphql): snippets split, improved, and lint #1287

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 8, 2022

Issue number: #1009

Summary

Changes

Please provide a summary of what's being changed

Split, lint, and improve code examples. Also noticed we didn't have a dedicated section for scalar_utils.

Also removed a pre-commit hook end-of-line fixer as it was causing productivity issues when splitting .json files.

User experience

Please share what the user experience looks like before and after this change

Before

image

After

image

(NEW) Properly documented scalar utils

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/core/event_handler/appsync.md

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Jul 8, 2022
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 8, 2022
@heitorlessa heitorlessa changed the title docs(event-handler): snippets split, improved, and lint docs(graphql): snippets split, improved, and lint Jul 8, 2022
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2022
@heitorlessa heitorlessa marked this pull request as ready for review July 11, 2022 07:11
@heitorlessa heitorlessa merged commit 92b475b into aws-powertools:develop Jul 11, 2022
@heitorlessa heitorlessa deleted the docs/event-handler-graphql-code-split branch July 11, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant