-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): add support for OpenAPI security schemes #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rubenfonseca
commented
Apr 17, 2024
aws_lambda_powertools/event_handler/openapi/swagger_ui/oauth2.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Ruben Fonseca <fonseka@gmail.com>
@leandrodamascena ready for your review |
leandrodamascena
previously approved these changes
Apr 18, 2024
leandrodamascena
previously approved these changes
Apr 18, 2024
@leandrodamascena sorry one last time, there was a logic error and we were always printing the warning |
|
leandrodamascena
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
event_handlers
feature
New feature or functionality
openapi-schema
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4036
Summary
This PR adds support for OpenAPI security schemes to OpenAPI generation and the Swagger UI.
Changes
User experience
For instance, here's how to declare an OAuth2 security scheme globally and test it on Swagger UI:
TODO
get_openapi_schema
is too complex (16 > 15)Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.