-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger-utils): preserve log level for discovered third-party top-level loggers #4299
Merged
leandrodamascena
merged 8 commits into
aws-powertools:develop
from
heitorlessa:feat/skip-log-level-utils
May 17, 2024
Merged
feat(logger-utils): preserve log level for discovered third-party top-level loggers #4299
leandrodamascena
merged 8 commits into
aws-powertools:develop
from
heitorlessa:feat/skip-log-level-utils
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
May 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4299 +/- ##
===========================================
- Coverage 96.38% 96.32% -0.06%
===========================================
Files 214 218 +4
Lines 10030 10451 +421
Branches 1846 1933 +87
===========================================
+ Hits 9667 10067 +400
- Misses 259 270 +11
- Partials 104 114 +10 ☔ View full report in Codecov by Sentry. |
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
May 8, 2024
heitorlessa
changed the title
fix(parameters): make cache aware of single vs multiple calls
feat(logger-utils): preserve log level for discovered third-party top-level loggers
May 8, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
May 8, 2024
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
May 8, 2024
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
May 8, 2024
github-actions
bot
added
feature
New feature or functionality
and removed
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
May 8, 2024
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
May 17, 2024
leandrodamascena
approved these changes
May 17, 2024
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
May 17, 2024
Quality Gate passedIssues Measures |
leandrodamascena
merged commit May 17, 2024
edf556e
into
aws-powertools:develop
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4226
Summary
This PR introduces a new parameter to keep log levels preserved in third-party loggers that we are copying Powertools config to.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.