Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add temporary pipeline for v3 #5026

Merged

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Aug 20, 2024

Issue number: #4826

Summary

Changes

After having developed and tested the v3 pipeline changes in a fork and personal AWS Account, we want to test the changes by running the pipeline against the BETA stage and without risking deploying to PROD.

Current state of the pipeline

image

The current version of the workflow has the following steps:

  1. Build the package, run checks, seal it, etc.
  2. Publish to PyPi using either full release version (i.e. 3.0.0) or nightly version (3.0.0.a1)
  3. Publish the Lambda Layers to the BETA stage
  4. Publish the Lambda Layers to the PROD stage
  5. Publish the Lambda Layers to the SAR BETA stage
  6. Publish the Lambda Layers to the SAR PROD stage
  7. Update docs, etc.

Proposed temporary state of the pipeline

image

To remove the risk of mistakes and inadvertently publish to the PROD stage, we are proposing to remove/comment out all the steps in the workflow that target any PROD stage, and leave only the ones for the BETA stage.

The resulting workflow would look like this:

  1. Build the package, run checks, seal it, etc.
  2. Publish to PyPi using dev version (i.e. 3.0.0.dev1)
  3. Publish the Lambda Layers to BETA stage
  4. Publish the Lambda Layers to the SAR BETA stage

Rolling back to desired state to production

I added a comment # UNCOMMENT on all the jobs that we need to uncomment to revert when we go to production.

The ./layer_v3 folder already exists in v3 branch and we don't need to push this to develop.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner August 20, 2024 11:17
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Aug 20, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 20, 2024
Copy link
Contributor

⚠️Large PR detected⚠️

Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.

@github-actions github-actions bot added the internal Maintenance changes label Aug 20, 2024
Copy link
Contributor

⚠️Large PR detected⚠️

Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.

@leandrodamascena leandrodamascena added the on-hold This item is on-hold and will be revisited in the future label Aug 21, 2024
Copy link
Contributor

⚠️Large PR detected⚠️

Please consider breaking into smaller PRs to avoid significant review delays. Ignore if this PR has naturally grown to this size after reviews.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we have removed SAR from the pipeline for the time being because it needs more attention.

Copy link

Copy link
Contributor

@sthulb sthulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but hard to verify without diffing from v2's release actions

@leandrodamascena leandrodamascena merged commit 4ee0e1d into aws-powertools:develop Aug 21, 2024
5 checks passed
@leandrodamascena leandrodamascena deleted the ci/v3-beta-layer branch August 21, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes on-hold This item is on-hold and will be revisited in the future size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants