Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add dump of govcloud layer info in verify step #5415

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Oct 21, 2024

Issue number: #5384

Summary

Changes

Please provide a summary of what's being changed

Adds a verification step as agreed in the runbook

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team as a code owner October 21, 2024 14:18
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Oct 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@github-actions github-actions bot added the internal Maintenance changes label Oct 21, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!!!!

.github/workflows/layer_govcloud_verify.yml Outdated Show resolved Hide resolved
.github/workflows/layer_govcloud_verify.yml Outdated Show resolved Hide resolved
sthulb and others added 2 commits October 21, 2024 17:10
Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
Copy link

@leandrodamascena leandrodamascena self-requested a review October 21, 2024 15:11
@sthulb sthulb merged commit 25d6404 into develop Oct 21, 2024
6 checks passed
@sthulb sthulb deleted the fix/govcloud_verification branch October 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants