-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature-flags): Add not_in action and rename contains to in #589
Merged
heitorlessa
merged 5 commits into
aws-powertools:develop
from
ran-isenberg:fun_with_flags
Aug 10, 2021
Merged
feat(feature-flags): Add not_in action and rename contains to in #589
heitorlessa
merged 5 commits into
aws-powertools:develop
from
ran-isenberg:fun_with_flags
Aug 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 5, 2021
ran-isenberg
changed the title
feat (feature flags): Add not_in action and rename contains to in
feat(feature flags): Add not_in action and rename contains to in
Aug 5, 2021
@heitorlessa there ya go |
Codecov Report
@@ Coverage Diff @@
## develop #589 +/- ##
========================================
Coverage 99.95% 99.95%
========================================
Files 113 113
Lines 4533 4534 +1
Branches 245 245
========================================
+ Hits 4531 4532 +1
Partials 2 2
Continue to review full report at Codecov.
|
heitorlessa
suggested changes
Aug 5, 2021
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
heitorlessa
approved these changes
Aug 10, 2021
heitorlessa
changed the title
feat(feature flags): Add not_in action and rename contains to in
feat(feature-flags): Add not_in action and rename contains to in
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature_flags
Feature Flags utility
feature
New feature or functionality
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Schema changes of condition keywords.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.