-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feature-flags): bug handling multiple conditions #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
…tion matches and other dont
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## develop #599 +/- ##
========================================
Coverage 99.95% 99.95%
========================================
Files 113 113
Lines 4535 4537 +2
Branches 245 246 +1
========================================
+ Hits 4533 4535 +2
Partials 2 2
Continue to review full report at Codecov.
|
ran-isenberg
changed the title
Bug in feature toggle - handling multiple conditions
fix(feature toggle) bug handling multiple conditions
Aug 10, 2021
ran-isenberg
changed the title
fix(feature toggle) bug handling multiple conditions
fix(feature toggle): bug handling multiple conditions
Aug 10, 2021
heitorlessa
changed the title
fix(feature toggle): bug handling multiple conditions
fix(feature flags): bug handling multiple conditions
Aug 10, 2021
heitorlessa
changed the title
fix(feature flags): bug handling multiple conditions
fix(feature-flags): bug handling multiple conditions
Aug 10, 2021
Lemme know when I can merge @risenberg-cyberark |
@heitorlessa good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #594
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.