Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-flags): bug handling multiple conditions #599

Merged
merged 8 commits into from
Aug 10, 2021

Conversation

ran-isenberg
Copy link
Contributor

@ran-isenberg ran-isenberg commented Aug 10, 2021

Issue #, if available: #594

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2021
@boring-cyborg boring-cyborg bot added the tests label Aug 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #599 (207cc2b) into develop (7b3b032) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #599   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          113      113           
  Lines         4535     4537    +2     
  Branches       245      246    +1     
========================================
+ Hits          4533     4535    +2     
  Partials         2        2           
Impacted Files Coverage Δ
...owertools/utilities/feature_flags/feature_flags.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3b032...207cc2b. Read the comment docs.

Ran Isenberg added 2 commits August 10, 2021 21:42
@ran-isenberg ran-isenberg changed the title Bug in feature toggle - handling multiple conditions fix(feature toggle) bug handling multiple conditions Aug 10, 2021
@ran-isenberg ran-isenberg changed the title fix(feature toggle) bug handling multiple conditions fix(feature toggle): bug handling multiple conditions Aug 10, 2021
@heitorlessa heitorlessa changed the title fix(feature toggle): bug handling multiple conditions fix(feature flags): bug handling multiple conditions Aug 10, 2021
@heitorlessa heitorlessa changed the title fix(feature flags): bug handling multiple conditions fix(feature-flags): bug handling multiple conditions Aug 10, 2021
@heitorlessa
Copy link
Contributor

Lemme know when I can merge @risenberg-cyberark

@ran-isenberg
Copy link
Contributor Author

@heitorlessa good to go

@heitorlessa heitorlessa added this to the 1.19.0 milestone Aug 10, 2021
@heitorlessa heitorlessa merged commit 06cd8da into aws-powertools:develop Aug 10, 2021
@heitorlessa heitorlessa added the bug Something isn't working label Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants