Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): support arm64 when developing locally #862

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Dec 1, 2021

Issue #, if available:

Description of changes:

Current version of regex library (2021.4.4) does not include a mac arm64 variant.
This causes black to fail on Apple Silicon

Other libraries would also be upgraded as part of this like:

  • bandit to 1.7.1
  • boto3/botocore to 1.20.17
  • coverage to 6.2
  • flake8-bugbear to 21.11.29

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Current version of regex library (2021.4.4) does not include a mac arm64 variant.
This causes black to fail on Apple Silicon
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Dec 1, 2021
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 1, 2021
@michaelbrewer
Copy link
Contributor Author

@heitorlessa this resolves builds on Apple Silicon

@codecov-commenter
Copy link

Codecov Report

Merging #862 (fd090e9) into develop (8cfa773) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #862    +/-   ##
=========================================
  Coverage    99.90%   99.90%            
=========================================
  Files          118      118            
  Lines         5125     5125            
  Branches       283      571   +288     
=========================================
  Hits          5120     5120            
  Misses           2        2            
  Partials         3        3            

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfa773...fd090e9. Read the comment docs.

@michaelbrewer michaelbrewer changed the title fix(deps): Run poetry upgrade to support arm64 fix(deps): Run poetry upgrade to support arm64 Dec 2, 2021
@heitorlessa heitorlessa changed the title fix(deps): Run poetry upgrade to support arm64 chore(deps): support arm64 when developing locally Dec 3, 2021
@heitorlessa heitorlessa merged commit 81fc02e into aws-powertools:develop Dec 3, 2021
@heitorlessa heitorlessa deleted the fix-deps-arm64 branch December 3, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants