Skip to content

Commit

Permalink
fix(all): fix latest release broken by change of npm pack result on c…
Browse files Browse the repository at this point in the history
…ommon (#470)

* Revert "fix(build): Update contributing.md and fix npm ci (#417)"

This reverts commit 279ad98.

* revert commons version
  • Loading branch information
flochaz authored Jan 14, 2022
1 parent d6aae13 commit 2c3df93
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 31 deletions.
10 changes: 4 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Please read through this document before submitting any issues or pull requests
information to effectively respond to your bug report or contribution.

## Security issue notifications

If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public GitHub issue.

## Reporting Bugs/Feature Requests
Expand Down Expand Up @@ -36,7 +35,7 @@ Contributions via pull requests are much appreciated. Before sending us a pull r
To send us a pull request, please follow these steps:

1. Fork the repository.
2. Install dependencies: `npm ci`
2. Install dependencies: `npm install`
3. Prepare utilities like commit hooks: `npm run init-environment`
4. Create a new branch to focus on the specific change you are contributing e.g. `git checkout -b improv/logger-debug-sampling`
5. Run all tests, and code baseline checks: `npm run test`
Expand All @@ -55,9 +54,8 @@ You might find useful to run both the documentation website and the API referenc
* **Docs website**:

You can build and start a local docs website by running these two commands.

* `npm run docs-buildDockerImage` OR `docker build -t squidfunk/mkdocs-material ./docs/`
* `npm run docs-runLocalDocker` OR `docker run --rm -it -p 8000:8000 -v ${PWD}:/docs squidfunk/mkdocs-material`
- `npm run docs-buildDockerImage` OR `docker build -t squidfunk/mkdocs-material ./docs/`
- `npm run docs-runLocalDocker` OR `docker run --rm -it -p 8000:8000 -v ${PWD}:/docs squidfunk/mkdocs-material`

### Tests

Expand Down Expand Up @@ -181,4 +179,4 @@ TODO

See the [LICENSE](LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.

We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
1 change: 0 additions & 1 deletion packages/commons/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"compilerOptions": {
"composite": true,
"experimentalDecorators": true,
"noImplicitAny": true,
"target": "ES2020",
Expand Down
4 changes: 2 additions & 2 deletions packages/logger/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/logger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"url": "https://github.com/awslabs/aws-lambda-powertools-typescript/issues"
},
"dependencies": {
"@aws-lambda-powertools/commons": "^0.3.0",
"@aws-lambda-powertools/commons": "^0.2.0",
"@middy/core": "^2.5.3",
"@types/aws-lambda": "^8.10.72",
"lodash.clonedeep": "^4.5.0",
Expand Down
5 changes: 0 additions & 5 deletions packages/logger/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,5 @@
"types": [
"jest",
"node"
],
"references": [
{
"path": "../commons"
}
]
}
4 changes: 2 additions & 2 deletions packages/metrics/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/metrics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"url": "https://github.com/awslabs/aws-lambda-powertools-typescript/issues"
},
"dependencies": {
"@aws-lambda-powertools/commons": "^0.3.0",
"@aws-lambda-powertools/commons": "^0.2.0",
"@types/aws-lambda": "^8.10.72"
}
}
5 changes: 0 additions & 5 deletions packages/metrics/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,5 @@
"types": [
"jest",
"node"
],
"references": [
{
"path": "../commons"
}
]
}
4 changes: 2 additions & 2 deletions packages/tracing/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/tracing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"url": "https://github.com/awslabs/aws-lambda-powertools-typescript/issues"
},
"dependencies": {
"@aws-lambda-powertools/commons": "^0.3.0",
"@aws-lambda-powertools/commons": "^0.2.0",
"@middy/core": "^2.5.3",
"aws-xray-sdk-core": "^3.3.3"
}
Expand Down
5 changes: 0 additions & 5 deletions packages/tracing/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,5 @@
"types": [
"jest",
"node"
],
"references": [
{
"path": "../commons"
}
]
}

0 comments on commit 2c3df93

Please sign in to comment.