Skip to content

Commit

Permalink
chore(maintenance): drop support for Node.js 14 (#1802)
Browse files Browse the repository at this point in the history
  • Loading branch information
dreamorosi committed Nov 24, 2023
1 parent 5361ad3 commit e2a0923
Show file tree
Hide file tree
Showing 36 changed files with 3,029 additions and 3,076 deletions.
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ body:
- 20.x
- 18.x
- 16.x
- 14.x
validations:
required: true
- type: dropdown
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
NODE_ENV: dev
strategy:
matrix:
version: [14, 16, 18, 20]
version: [16, 18, 20]
fail-fast: false
steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
packages/parameters,
packages/idempotency,
]
version: [14, 16, 18, 20]
version: [16, 18, 20]
arch: [x86_64, arm64]
fail-fast: false
steps:
Expand Down
2 changes: 1 addition & 1 deletion layers/src/canary-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class CanaryStack extends Stack {
'../tests/e2e/layerPublisher.class.test.functionCode.ts'
),
handler: 'handler',
runtime: Runtime.NODEJS_14_X,
runtime: Runtime.NODEJS_16_X,
functionName: `canary-${suffix}`,
timeout: Duration.seconds(30),
bundling: {
Expand Down
3 changes: 1 addition & 2 deletions layers/src/layer-publisher-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export class LayerPublisherStack extends Stack {
layerVersionName: props?.layerName,
description: `Powertools for AWS Lambda (TypeScript) version ${powertoolsPackageVersion}`,
compatibleRuntimes: [
Runtime.NODEJS_14_X,
Runtime.NODEJS_16_X,
Runtime.NODEJS_18_X,
Runtime.NODEJS_20_X,
Expand Down Expand Up @@ -109,7 +108,7 @@ export class LayerPublisherStack extends Stack {
'node_modules/@aws-sdk/**/README.md ',
];
const buildCommands: string[] = [];
// We need these modules because they are not included in the nodejs14x and nodejs16x runtimes
// We need these modules because they are not included in the nodejs16x runtimes
const modulesToInstall: string[] = [
'@aws-sdk/client-dynamodb',
'@aws-sdk/util-dynamodb',
Expand Down
2 changes: 1 addition & 1 deletion layers/tests/e2e/constants.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const RESOURCE_NAME_PREFIX = 'Layers-E2E';
export const ONE_MINUTE = 60 * 1000;
export const TEST_CASE_TIMEOUT = 3 * ONE_MINUTE;
export const SETUP_TIMEOUT = 5 * ONE_MINUTE;
export const SETUP_TIMEOUT = 7 * ONE_MINUTE;
export const TEARDOWN_TIMEOUT = 5 * ONE_MINUTE;
7 changes: 1 addition & 6 deletions layers/tests/unit/layer-publisher.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@ describe('Class: LayerPublisherStack', () => {
// Assess
template.resourceCountIs('AWS::Lambda::LayerVersion', 1);
template.hasResourceProperties('AWS::Lambda::LayerVersion', {
CompatibleRuntimes: [
'nodejs14.x',
'nodejs16.x',
'nodejs18.x',
'nodejs20.x',
],
CompatibleRuntimes: ['nodejs16.x', 'nodejs18.x', 'nodejs20.x'],
LicenseInfo: 'MIT-0',
/* CompatibleArchitectures: [
'x86_64',
Expand Down
Loading

0 comments on commit e2a0923

Please sign in to comment.