Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: integrate utility with CI/CD merge process #1097

Closed
2 tasks
ijemmy opened this issue Sep 29, 2022 · 3 comments
Closed
2 tasks

Maintenance: integrate utility with CI/CD merge process #1097

ijemmy opened this issue Sep 29, 2022 · 3 comments
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility

Comments

@ijemmy
Copy link
Contributor

ijemmy commented Sep 29, 2022

Description of the feature request

Problem statement
Every time a PR is merged a number of checks and actions are run on the utilities to make sure that the changes introduced are compatible with the existing code.

Additionally, the workflow that runs on merge also builds the documentation and API docs and publishes it.

Summary of the feature
This unit of work tracks the activities and changes needed for the new utility to be part of the merge workflow.

Code examples
N/A

Benefits for you and the wider AWS community
N/A

Describe alternatives you've considered
N/A

Additional context
N/A

Check list

  • Publish doc & api doc (blocked until the feature is completed)
  • Release (blocked until the feature is completed)
    • Sort out the versioning when we publish with lerna the idempotency utility. Right now we are at > 1.x tag for the core utilities but that cannot be the case for idempotency when we will publish it the first time

Out of scope

Related issues, RFCs

#447

@ijemmy ijemmy added automation This item relates to automation triage This item has not been triaged by a maintainer, please wait idempotency This item relates to the Idempotency Utility labels Sep 29, 2022
@ijemmy ijemmy self-assigned this Sep 29, 2022
@ijemmy ijemmy added the on-hold This item is on-hold and will be revisited in the future label Sep 29, 2022
@ijemmy
Copy link
Contributor Author

ijemmy commented Sep 29, 2022

Put this on-hold. Waiting for the implementation to be completed first.

@saragerion saragerion added this to the Idempotency milestone Sep 29, 2022
@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Nov 13, 2022
@dreamorosi dreamorosi changed the title Feature (idempotency): integrate utility with CI/CD merge process Maintenanc: integrate utility with CI/CD merge process Nov 14, 2022
@dreamorosi dreamorosi changed the title Maintenanc: integrate utility with CI/CD merge process Maintenance: integrate utility with CI/CD merge process Nov 14, 2022
@dreamorosi dreamorosi assigned dreamorosi and unassigned ijemmy Feb 7, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed on-hold This item is on-hold and will be revisited in the future labels Feb 7, 2023
@dreamorosi
Copy link
Contributor

Since this commit, testing and linting for the existing tests of this utility are being run when a PR is merged.

Closing the issue as completed.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility
Projects
None yet
Development

No branches or pull requests

3 participants