Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: write end-to-end tests for the utility #1098

Closed
ijemmy opened this issue Sep 29, 2022 · 3 comments · Fixed by #1442
Closed

Maintenance: write end-to-end tests for the utility #1098

ijemmy opened this issue Sep 29, 2022 · 3 comments · Fixed by #1442
Assignees
Labels
confirmed The scope is clear, ready for implementation idempotency This item relates to the Idempotency Utility tests PRs that add or change tests

Comments

@ijemmy
Copy link
Contributor

ijemmy commented Sep 29, 2022

Description of the feature request

Problem statement
Before a Powertools utility can be considered production ready it needs to have e2e tests implemented and running every time a new feature or release is added.

Summary of the feature
This action item tracks the activities and changes needed to integrate the new utility in the e2e tests, which high level and at the time of writing consist of:

Code examples
N/A

Benefits for you and the wider AWS community
Confidence that the utility has been tested in a real AWS Lambda execution environment.

Describe alternatives you've considered
N/A

Additional context
All utilities have extensive end to end test cases that aim at testing the different features and usages in a real AWS environment with real resources, permissions, and runtimes.

Related issues, RFCs

#447

@ijemmy ijemmy added triage This item has not been triaged by a maintainer, please wait idempotency This item relates to the Idempotency Utility labels Sep 29, 2022
@ijemmy ijemmy added the on-hold This item is on-hold and will be revisited in the future label Sep 29, 2022
@ijemmy
Copy link
Contributor Author

ijemmy commented Sep 29, 2022

Waiting for the implementation to be completed first.

@saragerion saragerion added this to the Idempotency milestone Sep 29, 2022
@dreamorosi dreamorosi added tests PRs that add or change tests and removed triage This item has not been triaged by a maintainer, please wait labels Nov 13, 2022
@dreamorosi dreamorosi changed the title Feature (idempotency): write end-to-end tests for the utility Maintenance: write end-to-end tests for the utility Nov 14, 2022
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed on-hold This item is on-hold and will be revisited in the future labels Apr 24, 2023
@dreamorosi
Copy link
Contributor

dreamorosi commented Apr 24, 2023

After discussing, it seems that after merging #1416 it would be a good time to start working on the integration tests for Idempotency.

As discussed, while testing, please also check whether the following issues can be closed or not; if not please consider commenting under them to report the missing delta:

Also, consider checking if it makes sense to move to commons the code that provisions the DynamoDB table in parameters so that we can reuse it here.

@dreamorosi dreamorosi linked a pull request May 11, 2023 that will close this issue
9 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The scope is clear, ready for implementation idempotency This item relates to the Idempotency Utility tests PRs that add or change tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants