-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): BasePersistenceLayer, DynamoDBPersistenceLayer and configs #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pull-request-size
bot
added
the
size/XXL
PRs with 1K+ LOC, largely documentation related
label
Mar 19, 2023
This was
linked to
issues
Mar 19, 2023
github-actions
bot
added
the
feature
PRs that introduce new features or minor changes
label
Mar 19, 2023
This was
linked to
issues
Mar 19, 2023
2 tasks
2 tasks
am29d
requested changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments.
packages/idempotency/src/persistence/DynamoDBPersistenceLayer.ts
Outdated
Show resolved
Hide resolved
am29d
approved these changes
Mar 30, 2023
dreamorosi
force-pushed
the
1294-dynamodb-persistence-layer
branch
from
March 30, 2023 15:16
1ccf9e7
to
932b909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR revisits the existing implementation of the DynamoDB persistence layer for Idempotency. The goal of this revision is aligning the implementation and feature set to the Powertools for Python version of this utility.
In doing so, I have also:
IdempotencyConfig
classBasePersistenceLayer
to include all the features and logic present in the Python version except for the local cachingWhile working on this PR, I have also revisited the imports for all files in the utility, as well as updating dependencies, and other housekeeping tasks.
Once merged, this PR will close #1158, #1294, #1295, #1296, #1297, #1301, #1302
How to verify this change
Check the newly added unit tests and compare the implementation with the one from Powertools for Python.
Related issues, RFCs
Issue number: #1294
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.