Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(layers): downgrade aws cdk to 2.145.0 #2700

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jun 27, 2024

Summary

Change in CDK that impacts ca-west-1: aws/aws-cdk#30108

Changes

Please provide a summary of what's being changed

This PR downgrades AWS CDK-related dependencies to 2.145.0 - last known working version for us - so that we can continue the release process for our packages.

I have verified that both aws-cdk and aws-cdk-lib are no longer present in our dependency tree by running npm ls <package-name>, below the results:

npm ls aws-cdk-lib                                                                
aws-lambda-powertools-typescript@0.0.1 /Users/aamorosi/Codes/aws-lambda-powertools-typescript
├─┬ @aws-lambda-powertools/testing-utils@2.3.0 -> ./packages/testing
│ └── aws-cdk-lib@2.145.0
├─┬ layers@2.3.0 -> ./layers
│ └── aws-cdk-lib@2.145.0
└─┬ powertools-sample-app@2.3.0 -> ./examples/app
  └── aws-cdk-lib@2.145.0


~/Codes/aws-lambda-powertools-typescript chore/downgrade_cdk*
❯ npm ls aws-cdk              
aws-lambda-powertools-typescript@0.0.1 /Users/aamorosi/Codes/aws-lambda-powertools-typescript
├─┬ layers@2.3.0 -> ./layers
│ └── aws-cdk@2.145.0
└─┬ powertools-sample-app@2.3.0 -> ./examples/app
  └── aws-cdk@2.145.0

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2699


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jun 27, 2024
@dreamorosi dreamorosi requested review from a team as code owners June 27, 2024 12:04
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation labels Jun 27, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jun 27, 2024
Copy link

sonarcloud bot commented Jun 27, 2024

@am29d am29d merged commit f976fe3 into main Jun 27, 2024
38 of 56 checks passed
@am29d am29d deleted the chore/downgrade_cdk branch June 27, 2024 12:08
dreamorosi added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: downgrade AWS CDK to 2.145.0
3 participants