Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(parameters): migrate tests to vitest #3304

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR migrates the unit and integration tests for the Parameters utility to use vitest in place of Jest.

The changes in the PR only change the imports and mocks, as well as rewriting the test headers to comply with the newer conventions introduced in the codebase.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3303


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Nov 11, 2024
@dreamorosi dreamorosi requested review from a team as code owners November 11, 2024 09:23
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility tests PRs that add or change tests labels Nov 11, 2024
@pull-request-size pull-request-size bot added the size/XXL PRs with 1K+ LOC, largely documentation related label Nov 11, 2024
@dreamorosi dreamorosi added the do-not-merge This item should not be merged label Nov 11, 2024
@dreamorosi
Copy link
Contributor Author

Integration tests are passing.

@dreamorosi dreamorosi requested a review from am29d November 11, 2024 10:23
@dreamorosi dreamorosi removed the do-not-merge This item should not be merged label Nov 11, 2024
Copy link

Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR, moving one step closer to full vitest support! I like the type tests, will probably use them in parser soon 👀 .

@am29d am29d merged commit 02b658a into main Nov 11, 2024
29 checks passed
@am29d am29d deleted the test/parameters_vitest branch November 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parameters This item relates to the Parameters Utility size/XXL PRs with 1K+ LOC, largely documentation related tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: migrate test runner to vitest for parameters package
2 participants