Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): adopted Utility class #548

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Feb 10, 2022

Description of your changes

This PR introduces changes to the Metrics module to adopt the forthcoming Utility class that will be released in the @aws-lambda-powertools/commons package.

  • Install released @aws-lambda-powertools/commons package
  • Make changes to the code to use the Utility class
  • Run unit & e2e tests
  • Add note in the docs about initialising utility outside of function handler (ref)

How to verify this change

See checks running on PR, see screenshot below for e2e tests ran locally:
image

Optionally re-run e2e on GitHub Action.

Related issues, RFCs

#484
#547

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added enhancement metrics This item relates to the Metrics Utility labels Feb 10, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Feb 10, 2022
@dreamorosi dreamorosi self-assigned this Feb 10, 2022
@dreamorosi dreamorosi added the on-hold This item is on-hold and will be revisited in the future label Feb 10, 2022
@dreamorosi
Copy link
Contributor Author

This PR is on hold until #547 is merged & released.

@dreamorosi dreamorosi removed the on-hold This item is on-hold and will be revisited in the future label Feb 17, 2022
@dreamorosi dreamorosi force-pushed the feat/metrics/adopt_utility_common_cold_start branch from e0119ba to 5af705f Compare February 17, 2022 15:12
@dreamorosi dreamorosi marked this pull request as ready for review February 17, 2022 15:12
Copy link
Contributor

@ijemmy ijemmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamorosi dreamorosi merged commit 672e6a8 into main Feb 22, 2022
@dreamorosi dreamorosi deleted the feat/metrics/adopt_utility_common_cold_start branch February 22, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics This item relates to the Metrics Utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants