[Docs] FluxCD - Use basic access auth for GitHub #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMcMahon
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
Fixes issue described aws-quickstart#999. Short version: the GitHub API for cloning doesn't work with bearer token.
JamesMcMahon
force-pushed
the
docs-fluxcd-github-auth
branch
from
80224e6
to
2f0dcce
Compare
|
@JamesMcMahon LGTM. Did you get a chance to test the functionality fully? Any logs you can share its working? |
|
/do-e2e-test |
|
/do-e2e-tests |
1 similar comment
|
/do-e2e-tests |
No - this is loosely based off work I have done fairly recently. Unfortunately, as I called out in the description, I no longer have access to a running cluster. Would appreciate a double check. |
|
@JamesMcMahon Sure, Can you merge from main, we had a recent merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue described #999.
Short version: the GitHub API for cloning doesn't work with bearer token.
Issue #, if available:
#999
Description of changes:
Update example to use GitHub basic access authentication. Note: I don't currently have access to an AWS cluster so I would appreciate if someone could double check my changes against a running cluster.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.