Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Construct for EKS blueprint #1018

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

bugathagit
Copy link
Contributor

Description of changes: Currently, EKS blueprint can be used by only cdk.stack users or the users who relies on stack derivates. All other users cannot use this package. So, this Generic construct will help the users of any kind to use eks blueprint code.

Example:
In our company, we use different stack named PipelineStack which is not able to use cdk.stack to deploy the resources created by the blueprint. Which resulted in writing our own blueprint/blueprint builder code. The current change will help to use the eks blueprint code directly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please see my comment, otherwise looks good.

lib/spi/types.ts Outdated Show resolved Hide resolved
@shapirov103
Copy link
Collaborator

/do-e2e-tests

aws-ia-ci
aws-ia-ci previously approved these changes Jun 20, 2024
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103 shapirov103 merged commit aa7904b into aws-quickstart:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants