-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Construct for EKS blueprint #1018
Generic Construct for EKS blueprint #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, please see my comment, otherwise looks good.
/do-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes: Currently, EKS blueprint can be used by only cdk.stack users or the users who relies on stack derivates. All other users cannot use this package. So, this Generic construct will help the users of any kind to use eks blueprint code.
Example:
In our company, we use different stack named PipelineStack which is not able to use cdk.stack to deploy the resources created by the blueprint. Which resulted in writing our own blueprint/blueprint builder code. The current change will help to use the eks blueprint code directly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.