Fix/cluster tags #662
Merged
Fix/cluster tags #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapirov103
reviewed
Apr 28, 2023
There was a problem hiding this comment.
@elamaran11 awesome change, only a couple of minor inline comments.
A bigger question is: it is odd that the change affects only Fargate and Generic cluster providers but not MngClusterProvider or AsgClusterProvider.
I realize that MngClusterProviderProps and such already have tags attribute but that was meant for the nodegroup tags, not the cluster.
If a customer passes tags with either MngClusterProvider or AsgClusterProvider, both node group and cluster will be tagged. This may be counter-intuitive.
Resolution:
- Rename tags clearly and use
clusterTagsvsnodeGroupTagsto avoid confusion across the board.
OR
- Use tags consistently across the board, however for Mng and Asg cases document that provided tags will apply both to the nodegroup and the cluster.
| @@ -2,6 +2,7 @@ import { Construct } from "constructs"; | |||
| import * as ec2 from "aws-cdk-lib/aws-ec2"; | |||
| import * as eks from "aws-cdk-lib/aws-eks"; | |||
| import { defaultOptions, GenericClusterProvider } from './generic-cluster-provider'; | |||
| import { Tags } from "aws-cdk-lib"; | |||
There was a problem hiding this comment.
Github actions warning - make lint please
| @@ -1,4 +1,4 @@ | |||
| # FluxCD Add-on | |||
shapirov103
approved these changes
Apr 28, 2023
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#631
Description of changes:
Tags for GenericClusterProvider and FargateClusterProvider.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.