Gpu Builder Instance Type prop fix #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Howlla
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
requested changes
Aug 30, 2023
elamaran11
requested changes
Sep 1, 2023
elamaran11
reviewed
Sep 4, 2023
There was a problem hiding this comment.
@Howlla Could you please make sure you tar the blueprints and test it on patterns. Since there is no e2e for builder classes, we need to test it before we can merge.
|
Sure
…On Mon, Sep 4, 2023 at 4:24 PM Ela AWS ***@***.***> wrote:
***@***.**** commented on this pull request.
@Howlla <https://github.com/Howlla> Could you please make sure you tar
the blueprints and test it on patterns. Since there is no e2e for builder
classes, we need to test it before we can merge.
—
Reply to this email directly, view it on GitHub
<#834 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHEWA6GONI2GNZQO5NOAQXDXYZBJPANCNFSM6AAAAAA4DYAW5M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@elamaran11 Tested in the gpu monitoring pattern here aws-samples/cdk-eks-blueprints-patterns#141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Concatenate instanceClass and instanceSize for instanceType prop
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.