Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Core Addons to support Default Versions from AWS sdk for different Kubernetes versions #904

Merged
merged 40 commits into from
Feb 5, 2024

Conversation

elamaran11
Copy link
Collaborator

@elamaran11 elamaran11 commented Jan 5, 2024

Issue #, if available: #812

Description of changes:
Upgrade Core Addons to support MAP of Versions for Kubernetes versions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11 elamaran11 changed the title Upgrade Core Addons to support MAP of Versions for Kubernetes versions Upgrade CoreDNS Addon to support MAP of Versions for Kubernetes versions Jan 5, 2024
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment.
we need to think about how to maintain these versions across releases. For example, step 1 could be making an API call at synth time and checking wether the version used is indeed the compatible/default version for the target EKS version.

lib/builders/observability-builder.ts Outdated Show resolved Hide resolved
@elamaran11
Copy link
Collaborator Author

one minor comment. we need to think about how to maintain these versions across releases. For example, step 1 could be making an API call at synth time and checking wether the version used is indeed the compatible/default version for the target EKS version.

Sounds look a good idea, lets discuss about this.

@elamaran11 elamaran11 changed the title Upgrade CoreDNS Addon to support MAP of Versions for Kubernetes versions Upgrade Core Addons to support Default Versions from AWS sdk for different Kubernetes versions Jan 11, 2024
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary feedback

test/coredns.test.ts Show resolved Hide resolved
lib/addons/core-addon/index.ts Outdated Show resolved Hide resolved
lib/addons/core-addon/index.ts Outdated Show resolved Hide resolved
lib/addons/core-addon/index.ts Outdated Show resolved Hide resolved
lib/addons/adot/index.ts Show resolved Hide resolved
@elamaran11
Copy link
Collaborator Author

Preliminary feedback

Fixed all comments, Please send a commit when you get a chance for jest fixes, we can make changes.

elamaran11 and others added 21 commits January 17, 2024 11:29
@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@shapirov103 shapirov103 merged commit 6b6dad6 into main Feb 5, 2024
1 check passed
@shapirov103 shapirov103 deleted the feature/upgradeCoreAddons branch February 5, 2024 14:48
@elamaran11 elamaran11 linked an issue Feb 6, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(CoreDNS Addon) Support for MAP to support version based on Kubernetes version.
4 participants