Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Istio Suite of Addons with CNI and Ingress Gateway Addons. #928

Merged
merged 30 commits into from
Feb 28, 2024

Conversation

elamaran11
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, I think it is a great start but we will need to solve the use cases I mentioned in the comments.

lib/addons/istio-addons/istio-cni.ts Outdated Show resolved Hide resolved
lib/addons/istio-addons/istio-cni.ts Show resolved Hide resolved
lib/addons/istio-addons/istio-cni.ts Outdated Show resolved Hide resolved
docs/addons/istio-cni.md Show resolved Hide resolved
@elamaran11
Copy link
Collaborator Author

Added a few comments, I think it is a great start but we will need to solve the use cases I mentioned in the comments.

@shapirov103 All Comments fixed, resolved, please double check and let me know.

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

2 similar comments
@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@shapirov103 shapirov103 merged commit ba6c1b0 into main Feb 28, 2024
2 checks passed
@shapirov103 shapirov103 deleted the feature/upgradeIstiAddons branch February 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Istio Addons are not extensible to deploy istio-ingressgateway and istio-cni
4 participants