Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EBS CSI Driver Issue - Avoiding CoreAddonProps to be filled out #954

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

elamaran11
Copy link
Collaborator

Issue #, if available:

Description of changes:
Fix EBS CSI Driver Issue - Avoiding CoreAddonProps to be filled out

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elamaran11 please see my comment.

lib/addons/ebs-csi-driver/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY!

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@elamaran11
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11 elamaran11 merged commit ccd3a51 into main Mar 15, 2024
1 check passed
@elamaran11 elamaran11 deleted the fix/ebsCsiAddon branch March 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(EBS CSI Driver): (Fix EBS CSI Driver Issue - Avoiding CoreAddonProps to be filled)
3 participants