Migrated CloudWatch Insights to new CoreAddons model #994
Conversation
5herlocked
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
There was a problem hiding this comment.
@5herlocked Minor feedback on versionMap, @shapirov103 double check from your end. This is for issue #971
There was a problem hiding this comment.
@5herlocked have you validated that 1/ addon creates correct service account and 2/ you can set the version explicitly, or auto as well ?
I have validated both |
There was a problem hiding this comment.
@5herlocked please address the minor comment, before submitting please make sure you run all commands specified https://github.com/aws-quickstart/cdk-eks-blueprints/blob/main/docs/internal/readme-internal.md#submitting-pull-requests.
npm i
make build
make lint
make run-test
cdk list
| .addOns(new blueprints.CloudWatchInsights()) | ||
| .buildAsync(app, 'cloudwatch'); | ||
|
|
||
| const template = Template.fromStack(blueprint); |
There was a problem hiding this comment.
github code quality issue here. please run make lint
5herlocked
force-pushed
the
container-insights
branch
from
fc817b1
to
7f5d5b9
Compare
Issue #, if available: #971, #948
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.