Use Stack ID for OriginAccessControl.Name property #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svozza
approved these changes
Sep 19, 2023
svozza
approved these changes
Sep 19, 2023
svozza
reviewed
Sep 21, 2023
templates/cloudfront-site.yaml
Outdated
| Name: !Sub 'oac-${AWS::StackName}' | ||
| # Get a unique ID for the OAC Config name. | ||
| # Name must be unique within account | ||
| Name: !Select [2, !Split ['/', !Ref 'AWS::StackId']] |
There was a problem hiding this comment.
You might want to put some indication of what application owns the OAC so customers can tell at a glance in the console.
Name: !Sub
- amzn-secure-static-site-${guid}
- guid: !Select [2, !Split ['/', !Ref 'AWS::StackId']]
ConnorKirk
changed the title
ConnorKirk
force-pushed
the
fix-origin-access-config-name-length-issue
branch
from
1a76f1d
to
d861ec0
Compare
svozza
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #67 and #66
Description of changes:
OriginAccessControl.NamepropertyThe template fails to deploy when the stack name is longer than 64 characters. The
OriginAccessControlConfigresource fails to create, with a genericInvalidRequesterror. TheNameproperty has. a max length of 64 characters.The
OriginAccessControlConfig.Nameproperty was set to!Sub oac-${AWS::StackName}-${AWS::Region}'.For sufficiently long stack names (including the default stack name), this triggered the bug described above.OriginAccessControlConfig
resources must have a unique name across all regions for an account. To ensure this, theName` property was derived from both the StackName and Region. The max length of a stack name is 128 characters. This is longer than the 64 characters allowed by the OACConfig Name property.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.