Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct step increment for top p value #114

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

massi-ang
Copy link
Collaborator

Issue #, if available:
Fix #113

Description of changes:
Set the step value to 0.1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bigadsoleiman bigadsoleiman merged commit 74c75f3 into aws-samples:main Oct 15, 2023
@massi-ang massi-ang deleted the fix_top_p_values branch March 8, 2024 17:46
lloydclowes pushed a commit to lloydclowes/gen-ai-playground that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Top P value can only be set to 0, 0.1 and 1 values
2 participants