Correctly switch interface based on chat history and model capabilities #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hatbot into fix_multimodal_chat
When deciding which interface to use (multimodal or langchain), consider also the InputModalities of the selected model
bigadsoleiman
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
To allow for multimodal models, like Claude 3, to be used both for multimodal chat and RAG we selected which interface to use based on the presence of images in the user input or in the chat history.
This logic does not work if the user starts a multimodal chat (using images) and then switches to a text-only model, since we would still route the input to the multimodal interface which does not recognize the selected model
Description of changes:
We added a check to the existing conditions to verify that the selected model has IMAGE input modality support.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.